diff options
| author | modimo <modimo@fb.com> | 2020-12-03 09:23:37 -0800 |
|---|---|---|
| committer | modimo <modimo@fb.com> | 2020-12-03 09:23:37 -0800 |
| commit | 18603319321a6c1b158800bcc60035ee01549516 (patch) | |
| tree | 0b914aae5b1fdcc20cbd8f48a4ba5058adee9ab7 /llvm/lib/Support/Unicode.cpp | |
| parent | c8d406c93c5bb01599990201f78d8428dd29d289 (diff) | |
| download | llvm-18603319321a6c1b158800bcc60035ee01549516.zip llvm-18603319321a6c1b158800bcc60035ee01549516.tar.gz llvm-18603319321a6c1b158800bcc60035ee01549516.tar.bz2 | |
[MemCpyOpt] Correctly merge alias scopes during call slot optimization
When MemCpyOpt performs call slot optimization it will concatenate the `alias.scope` metadata between the function call and the memcpy. However, scoped AA relies on the domains in metadata to be maintained in a caller-callee relationship. Naive concatenation breaks this assumption leading to bad AA results.
The fix is to take the intersection of domains then union the scopes within those domains.
The original bug came from a case of rust bad codegen which uses this bad aliasing to perform additional memcpy optimizations. As show in the added test case `%src` got forwarded past its lifetime leading to a dereference of garbage data.
Testing
ninja check-llvm
Reviewed By: jeroen.dobbelaere
Differential Revision: https://reviews.llvm.org/D91576
Diffstat (limited to 'llvm/lib/Support/Unicode.cpp')
0 files changed, 0 insertions, 0 deletions