diff options
author | Chuanqi Xu <yedeng.yd@linux.alibaba.com> | 2024-02-01 13:44:32 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-01 13:44:32 +0800 |
commit | 8eea582dcb900afb45866a09296624b6fef9dd20 (patch) | |
tree | 2146d7b106a0ef7e4cc81565fa0b8f17c0419f93 /llvm/lib/Support/StringRef.cpp | |
parent | c82a645ef2421c29b5e0000e981b90dc9a1e1137 (diff) | |
download | llvm-8eea582dcb900afb45866a09296624b6fef9dd20.zip llvm-8eea582dcb900afb45866a09296624b6fef9dd20.tar.gz llvm-8eea582dcb900afb45866a09296624b6fef9dd20.tar.bz2 |
[C++20] [Modules] Introduce -fskip-odr-check-in-gmf (#79959)
Close https://github.com/llvm/llvm-project/issues/79240
Cite the comment from @mizvekov in
//github.com/llvm/llvm-project/issues/79240:
> There are two kinds of bugs / issues relevant here:
>
> Clang bugs that this change hides
> Here we can add a Frontend flag that disables the GMF ODR check, just
> so
> we can keep tracking, testing and fixing these issues.
> The Driver would just always pass that flag.
> We could add that flag in this current issue.
> Bugs in user code:
> I don't think it's worth adding a corresponding Driver flag for
> controlling the above Frontend flag, since we intend it's behavior to
> become default as we fix the problems, and users interested in testing
> the more strict behavior can just use the Frontend flag directly.
This patch follows the suggestion:
- Introduce the CC1 flag `-fskip-odr-check-in-gmf` which is by default
off, so that the every existing test will still be tested with checking
ODR violations.
- Passing `-fskip-odr-check-in-gmf` in the driver to keep the behavior
we intended.
- Edit the document to tell the users who are still interested in more
strict checks can use `-Xclang -fno-skip-odr-check-in-gmf` to get the
existing behavior.
Diffstat (limited to 'llvm/lib/Support/StringRef.cpp')
0 files changed, 0 insertions, 0 deletions