diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2014-03-06 04:13:12 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2014-03-06 04:13:12 +0000 |
| commit | 3c57aa4111289fb51026dae96739aaa3d20c7d3c (patch) | |
| tree | 77aefd45b9ca3150050c268621030e3d226894da /llvm/lib/Support/SourceMgr.cpp | |
| parent | 8845dbd7987ce70c4a8fa057742e11454651f509 (diff) | |
| download | llvm-3c57aa4111289fb51026dae96739aaa3d20c7d3c.zip llvm-3c57aa4111289fb51026dae96739aaa3d20c7d3c.tar.gz llvm-3c57aa4111289fb51026dae96739aaa3d20c7d3c.tar.bz2 | |
[Modules] Fix a layering issue that is actually impacting the modules
selfhost.
The 'Core.h' C-API header is part of the IR LLVM library. (One might
even argue it should be called IR.h, but that's a separate point.) We
can't include it into a Support header without violating the layering,
and in a way that breaks modules. MemoryBuffer's opaque C type was being
defined in the Core.h C-API header despite being in the Support library,
and thus we ended up with this weird issue.
It turns out that there were other constructs from the Support library
in the Core.h header. This patch lifts all of them into Support.h and
then includes that into Core.h.
The only possible fallout is if someone was including Support.h and
relying on Core.h to be visible for their own uses. Considering the
narrow interface actually provided by the C-API for the Support library,
this seems a very, very unlikely mistake.
llvm-svn: 203071
Diffstat (limited to 'llvm/lib/Support/SourceMgr.cpp')
0 files changed, 0 insertions, 0 deletions