diff options
| author | Hal Finkel <hfinkel@anl.gov> | 2013-07-15 20:22:58 +0000 |
|---|---|---|
| committer | Hal Finkel <hfinkel@anl.gov> | 2013-07-15 20:22:58 +0000 |
| commit | 8e8618ae5c0cd2ca06d170e05154ff70e159044e (patch) | |
| tree | 56b2df31dd3148291f4342957c98a278b8a4a0e0 /llvm/lib/Support/MemoryBuffer.cpp | |
| parent | bad7fb09b2d16e396365f25d9b4c43a57feced2d (diff) | |
| download | llvm-8e8618ae5c0cd2ca06d170e05154ff70e159044e.zip llvm-8e8618ae5c0cd2ca06d170e05154ff70e159044e.tar.gz llvm-8e8618ae5c0cd2ca06d170e05154ff70e159044e.tar.bz2 | |
Fix register subclass handling in PPCInstrInfo::insertSelect
PPCInstrInfo::insertSelect and PPCInstrInfo::canInsertSelect were computing the
common subclass of the true and false inputs, and then selecting either the
32-bit or the 64-bit isel variant based on the result of calling
PPC::GPRCRegClass.hasSubClassEq(RC) and PPC::G8RCRegClass.hasSubClassEq(RC)
(where RC is the common subclass). Unfortunately, this is not quite right: if
we have something like this:
%vreg8<def> = SELECT_CC_I8 %vreg4<kill>, %vreg7<kill>, %vreg6<kill>, 76;
G8RC_and_G8RC_NOX0:%vreg8 CRRC:%vreg4 G8RC_NOX0:%vreg7,%vreg6
then the common subclass of G8RC_and_G8RC_NOX0 and G8RC_NOX0 is G8RC_NOX0, and
G8RC_NOX0 is not a subclass of G8RC (because it also contains the ZERO8
pseudo-register). As a result, we also need to check the common subclass
against GPRC_NOR0 and G8RC_NOX0 explicitly.
This had not been a problem for clients of insertSelect that called
canInsertSelect first (because it had a compensating mistake), but insertSelect
is also used by the PPC pseudo-instruction expander, and this error was causing
a problem in that context.
This problem was found by csmith.
llvm-svn: 186343
Diffstat (limited to 'llvm/lib/Support/MemoryBuffer.cpp')
0 files changed, 0 insertions, 0 deletions
