diff options
| author | Fred Riss <friss@apple.com> | 2020-03-19 08:43:41 -0700 |
|---|---|---|
| committer | Fred Riss <friss@apple.com> | 2020-03-23 14:34:17 -0700 |
| commit | b6ae8937e031cde2e70e6a83d46c21e940fdf4ac (patch) | |
| tree | 6e2b48ef2842c27c16789ada81a8cf8b177d58a5 /llvm/lib/Support/LockFileManager.cpp | |
| parent | f3018068517e350f509b40f50207db25f80ff6fc (diff) | |
| download | llvm-b6ae8937e031cde2e70e6a83d46c21e940fdf4ac.zip llvm-b6ae8937e031cde2e70e6a83d46c21e940fdf4ac.tar.gz llvm-b6ae8937e031cde2e70e6a83d46c21e940fdf4ac.tar.bz2 | |
[lldb/PlatformDarwin] Always delete destination file first in PutFile
Summary:
The default behavior of Platform::PutFile is to open the file and
truncate it if it already exists. This works fine and is a sensible
default, but it interacts badly with code-signing on iOS, as doing so
invalidates the signature of the file (even if the new content has a
valid code signature).
We have a couple tests which on purpose reload a different binary with
the same name. Those tests are currently broken because of the above
interaction.
This patch simply makes the Darwin platform unconditionally delete the
destination file before sending the new one to work around this issue.
Reviewers: jasonmolenda
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76450
Diffstat (limited to 'llvm/lib/Support/LockFileManager.cpp')
0 files changed, 0 insertions, 0 deletions