diff options
author | Youngsuk Kim <youngsuk.kim@hpe.com> | 2024-07-03 05:34:28 -0500 |
---|---|---|
committer | Youngsuk Kim <youngsuk.kim@hpe.com> | 2024-07-03 06:37:48 -0500 |
commit | 82f9a5ba965dc1a40fe955b8205dd863bf6385cf (patch) | |
tree | 0a78e22f08eee30a7d2bcde15153e2971ada9c93 /llvm/lib/Support/LockFileManager.cpp | |
parent | d37e7ec2c5c3ecfd6a4612c1798d62d343ceb254 (diff) | |
download | llvm-82f9a5ba965dc1a40fe955b8205dd863bf6385cf.zip llvm-82f9a5ba965dc1a40fe955b8205dd863bf6385cf.tar.gz llvm-82f9a5ba965dc1a40fe955b8205dd863bf6385cf.tar.bz2 |
[llvm] Avoid 'raw_string_ostream::str' (NFC)
Since `raw_string_ostream` doesn't own the string buffer, it is
desirable (in terms of memory safety) for users to directly reference
the string buffer rather than use `raw_string_ostream::str()`.
Work towards TODO comment to remove `raw_string_ostream::str()`.
Diffstat (limited to 'llvm/lib/Support/LockFileManager.cpp')
-rw-r--r-- | llvm/lib/Support/LockFileManager.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Support/LockFileManager.cpp b/llvm/lib/Support/LockFileManager.cpp index 3169aa2..ea040cc 100644 --- a/llvm/lib/Support/LockFileManager.cpp +++ b/llvm/lib/Support/LockFileManager.cpp @@ -228,7 +228,7 @@ LockFileManager::LockFileManager(StringRef FileName) std::string S("failed to create link "); raw_string_ostream OSS(S); OSS << LockFileName.str() << " to " << UniqueLockFileName.str(); - setError(EC, OSS.str()); + setError(EC, S); return; } @@ -274,7 +274,7 @@ std::string LockFileManager::getErrorMessage() const { raw_string_ostream OSS(Str); if (!ErrCodeMsg.empty()) OSS << ": " << ErrCodeMsg; - return OSS.str(); + return Str; } return ""; } |