diff options
author | Rui Ueyama <ruiu@google.com> | 2018-04-17 21:09:16 +0000 |
---|---|---|
committer | Rui Ueyama <ruiu@google.com> | 2018-04-17 21:09:16 +0000 |
commit | e6ac9f5ec3b890885abef8c4a315203ef02a25e5 (patch) | |
tree | 4f5c9383a696cb4501c0a9c9f2cd9e96c4d9b4bc /llvm/lib/Support/InitLLVM.cpp | |
parent | 4576dc06beca1889c8e5ab8fd12306f44a8e2828 (diff) | |
download | llvm-e6ac9f5ec3b890885abef8c4a315203ef02a25e5.zip llvm-e6ac9f5ec3b890885abef8c4a315203ef02a25e5.tar.gz llvm-e6ac9f5ec3b890885abef8c4a315203ef02a25e5.tar.bz2 |
Rename sys::Process::GetArgumentVector -> sys::windows::GetCommandLineArguments
GetArgumentVector (or GetCommandLineArguments) is very Windows-specific.
I think it doesn't make much sense to provide that function from sys::Process.
I also made a change so that the function takes a BumpPtrAllocator
instead of a SpecificBumpPtrAllocator. The latter is the class to call
dtors, but since char * is trivially destructible, we should use the
former class.
Differential Revision: https://reviews.llvm.org/D45641
llvm-svn: 330216
Diffstat (limited to 'llvm/lib/Support/InitLLVM.cpp')
-rw-r--r-- | llvm/lib/Support/InitLLVM.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/llvm/lib/Support/InitLLVM.cpp b/llvm/lib/Support/InitLLVM.cpp index c76b1bd..c008d04 100644 --- a/llvm/lib/Support/InitLLVM.cpp +++ b/llvm/lib/Support/InitLLVM.cpp @@ -15,7 +15,12 @@ #include "llvm/Support/Signals.h" #include <string> +#ifdef _WIN32 +#include "Windows/WindowsSupport.h" +#endif + using namespace llvm; +using namespace llvm::sys; InitLLVM::InitLLVM(int &Argc, const char **&Argv) : StackPrinter(Argc, Argv) { sys::PrintStackTraceOnErrorSignal(Argv[0]); @@ -33,11 +38,10 @@ InitLLVM::InitLLVM(int &Argc, const char **&Argv) : StackPrinter(Argc, Argv) { std::string Banner = std::string(Argv[0]) + ": "; ExitOnError ExitOnErr(Banner); - ExitOnErr(errorCodeToError( - sys::Process::GetArgumentVector(Args, makeArrayRef(Argv, Argc), Alloc))); + ExitOnErr(errorCodeToError(windows::GetCommandLineArguments(Args, Alloc))); - // GetArgumentVector doesn't terminate the vector with a nullptr. - // Do it to make it compatible with the real argv. + // GetCommandLineArguments doesn't terminate the vector with a + // nullptr. Do it to make it compatible with the real argv. Args.push_back(nullptr); Argc = Args.size() - 1; |