diff options
| author | Craig Topper <craig.topper@intel.com> | 2018-08-24 17:48:25 +0000 |
|---|---|---|
| committer | Craig Topper <craig.topper@intel.com> | 2018-08-24 17:48:25 +0000 |
| commit | d8e91c3e8d8e7a83799337757d6e8af3a4189b5b (patch) | |
| tree | ad4fd85880d002e34ab7ffc5e5c2d27541037d64 /llvm/lib/Support/FileOutputBuffer.cpp | |
| parent | 7cb44f2470dc61d267096fc2354d6862db69b075 (diff) | |
| download | llvm-d8e91c3e8d8e7a83799337757d6e8af3a4189b5b.zip llvm-d8e91c3e8d8e7a83799337757d6e8af3a4189b5b.tar.gz llvm-d8e91c3e8d8e7a83799337757d6e8af3a4189b5b.tar.bz2 | |
[DAGCombiner][Mips] Don't combine bitcast+store after LegalOperations when the store is volatile, if the resulting store isn't Legal
Previously we allowed the store to be Custom. But without knowing for sure that the Custom handling won't split the store, we shouldn't convert a volatile store. We also probably shouldn't be creating a store the requires custom handling after LegalizeOps. This could lead to an infinite loop if the custom handling was to insert a bitcast. Though I guess isStoreBitCastBeneficial could be used to block such a loop.
The test changes here are due to the volatile part of this. The stores in the test are all volatile and i32 stores are marked custom, So we are no longer converting them
This is related to D50491 where I was trying to allow some bitcasting of volatile loads
Differential Revision: https://reviews.llvm.org/D50578
llvm-svn: 340626
Diffstat (limited to 'llvm/lib/Support/FileOutputBuffer.cpp')
0 files changed, 0 insertions, 0 deletions