diff options
| author | Johan Vikstrom <jvikstrom@google.com> | 2019-08-08 12:43:55 +0000 |
|---|---|---|
| committer | Johan Vikstrom <jvikstrom@google.com> | 2019-08-08 12:43:55 +0000 |
| commit | b865d5a425ec17403eb77ea8175863a310ad6668 (patch) | |
| tree | 2ee274bc4190332714110c97efa15ed520e2e56a /llvm/lib/Support/FileCheck.cpp | |
| parent | df13b9393de6583dfa3102be7fee5c8a47c0c570 (diff) | |
| download | llvm-b865d5a425ec17403eb77ea8175863a310ad6668.zip llvm-b865d5a425ec17403eb77ea8175863a310ad6668.tar.gz llvm-b865d5a425ec17403eb77ea8175863a310ad6668.tar.bz2 | |
[clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if underlying MemberDecl is a CXXConversionDecl.
Summary:
Conversion operators contain invalid MemberLocs which caused SemanticHighlighting
to emit a lot of error logs in large files as they can occur fairly
often (for example converting StringRef to std string).
As the only thing happening was a lot of error logs being
emited there doesn't really seem to be any way to test this
(no erroneous tokens are added). But emiting as many logs as
were being emited is not wanted.
This also adds a test to guard against regressions for highlightings
disapearing from places where the conversion operators are used as their
behaviour differ from the other CXXMethodDecls.
Reviewers: hokein, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D65928
llvm-svn: 368287
Diffstat (limited to 'llvm/lib/Support/FileCheck.cpp')
0 files changed, 0 insertions, 0 deletions