diff options
author | Paul Hoad <mydeveloperday@gmail.com> | 2019-10-01 20:20:22 +0000 |
---|---|---|
committer | Paul Hoad <mydeveloperday@gmail.com> | 2019-10-01 20:20:22 +0000 |
commit | 603650213b1aee2a03ba879ba9d8e6eb65a06694 (patch) | |
tree | 540d876fba6d243653a85ecd0a4d675042ddc0b4 /llvm/lib/Support/FileCheck.cpp | |
parent | 2df5f12ea119ea653c92fee347ef5a00ca64f0ad (diff) | |
download | llvm-603650213b1aee2a03ba879ba9d8e6eb65a06694.zip llvm-603650213b1aee2a03ba879ba9d8e6eb65a06694.tar.gz llvm-603650213b1aee2a03ba879ba9d8e6eb65a06694.tar.bz2 |
[clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed
Summary:
This is a patch to fix PR43372 (https://bugs.llvm.org/show_bug.cgi?id=43372) - clang-format can't format file with includes, ( which really keep providing replacements for already sorted headers.)
A similar issue was addressed by @krasimir in {D60199}, however, this seemingly only prevented the issue when the files being formatted did not contain windows line endings (\r\n)
It's possible this is related to https://twitter.com/StephanTLavavej/status/1176722938243895296 given who @STL_MSFT works for!
As people often used the existence of replacements to determine if a file needs clang-formatting, this is probably pretty important for windows users
There may be a better way of comparing 2 strings and ignoring \r (which appear in both Results and Code), I couldn't choose between this idiom or the copy_if approach, but I'm happy to change it to whatever people consider more performant.
Reviewers: krasimir, klimek, owenpan, ioeric
Reviewed By: krasimir
Subscribers: cfe-commits, STL_MSFT, krasimir
Tags: #clang-format, #clang, #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D68227
llvm-svn: 373388
Diffstat (limited to 'llvm/lib/Support/FileCheck.cpp')
0 files changed, 0 insertions, 0 deletions