diff options
author | Hans Wennborg <hans@hanshq.net> | 2013-10-17 01:13:02 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2013-10-17 01:13:02 +0000 |
commit | 69918bccab95155bfa9c525d11dbdf016bc61e47 (patch) | |
tree | dcfb1ebadb06982c61998b655213bfcbba209235 /llvm/lib/Support/ErrorHandling.cpp | |
parent | 312bcbe8b4820d66feb17949622c7c5cb4a5fb49 (diff) | |
download | llvm-69918bccab95155bfa9c525d11dbdf016bc61e47.zip llvm-69918bccab95155bfa9c525d11dbdf016bc61e47.tar.gz llvm-69918bccab95155bfa9c525d11dbdf016bc61e47.tar.bz2 |
Re-commit r192758 - MC: quote tricky symbol names in asm output
The reason this got reverted was that the @feat.00 symbol which was emitted
for every TU became quoted, and on cygwin/mingw we use the gas assembler which
couldn't handle the quotes.
This commit fixes the problem by only emitting @feat.00 for win32, where we use
clang -cc1as to assemble. gas would just drop this symbol anyway, so there is no
loss there.
With @feat.00 gone, there shouldn't be quoted symbols showing up on cygwin since
it uses the Itanium ABI, which doesn't put these funny characters in symbols.
> Because of win32 mangling, we produce symbol and section names with
> funny characters in them, most notably @ characters.
>
> MC would choke on trying to parse its own assembly output. This patch addresses
> that by:
>
> - Making @ trigger quoting of symbol names
> - Also quote section names in the same way
> - Just parse section names like other identifiers (to allow for quotes)
> - Don't assume @ signifies a symbol variant if it is in a string.
llvm-svn: 192859
Diffstat (limited to 'llvm/lib/Support/ErrorHandling.cpp')
0 files changed, 0 insertions, 0 deletions