diff options
| author | Sean Silva <silvasean@google.com> | 2020-05-26 20:14:34 -0700 |
|---|---|---|
| committer | Sean Silva <silvasean@google.com> | 2020-05-27 13:26:03 -0700 |
| commit | b2773823116157aa73ea4ac01270b22042d6bb42 (patch) | |
| tree | 5c3e5d3be48c871c346defd4dd9f4f66e829c448 /llvm/lib/Support/CommandLine.cpp | |
| parent | 54b64572407c8305c7bb8cc20c46a5e0c66b2979 (diff) | |
| download | llvm-b2773823116157aa73ea4ac01270b22042d6bb42.zip llvm-b2773823116157aa73ea4ac01270b22042d6bb42.tar.gz llvm-b2773823116157aa73ea4ac01270b22042d6bb42.tar.bz2 | |
Remove error-prone mlir::ExecutionEngine::invoke overload.
I just spent a bunch of time debugging a mysterious bug that ended being due to my SmallVector getting passed to the Args&... overload instead of the MutableArrayRef overload, with disastrous results.
I appreciate the intent of this API, but for a function that does a bunch of unsafe casts, adding in potential overload confusion is just too much C++ footgun. If we end up needing this functionality, having something like a separate `packArgs(Args&...) -> SmallVector` overload would be preferable.
Turns out this API is unused and untested (even out of tree as far as I can tell, modulo the optional passing of no args to the other invoke as I fixed in this patch), so it's an easy fix -- just delete it and touch up the other overload.
Differential Revision: https://reviews.llvm.org/D80607
Diffstat (limited to 'llvm/lib/Support/CommandLine.cpp')
0 files changed, 0 insertions, 0 deletions