diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-05-12 12:13:52 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-12 12:13:52 -0700 |
commit | 9c5f451d1c59b4e35742b572bee6576a44e10672 (patch) | |
tree | afbbfc3ff57871e7aa9998ce556ece7582c0e14b /llvm/lib/Support/CommandLine.cpp | |
parent | 9f8ff4b77d07570294a020c24bc347285c3affdc (diff) | |
download | llvm-9c5f451d1c59b4e35742b572bee6576a44e10672.zip llvm-9c5f451d1c59b4e35742b572bee6576a44e10672.tar.gz llvm-9c5f451d1c59b4e35742b572bee6576a44e10672.tar.bz2 |
[llvm] annotate interfaces in llvm/Support for DLL export (#136014)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/Support` library.
These annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Add `#include "llvm/Support/Compiler.h"` to files where it was not
auto-added by IDS due to no pre-existing block of include statements.
- Add `LLVM_ABI` to Windows-only code (auto generated with IDS on
Windows)
- Explicitly make classes non-copyable where needed to due IDS adding
`LLVM_ABI` at the class level
- Add `LLVM_TEMPLATE_ABI` and `LLVM_EXPORT_TEMPLATE` to exported
instantiated templates
- Add `LLVM_ABI_FRIEND` to a small number of `friend` function
declarations
- Add `LLVM_ABI` to a subset of private class methods and fields that
require export
- Add `LLVM_ABI` to a small number of symbols that require export but
are not declared in headers
- Add `LLVM_ABI` functions defined via X-macro
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'llvm/lib/Support/CommandLine.cpp')
-rw-r--r-- | llvm/lib/Support/CommandLine.cpp | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp index a407be9..49cefb1 100644 --- a/llvm/lib/Support/CommandLine.cpp +++ b/llvm/lib/Support/CommandLine.cpp @@ -29,6 +29,7 @@ #include "llvm/ADT/StringRef.h" #include "llvm/ADT/Twine.h" #include "llvm/Config/config.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/ConvertUTF.h" #include "llvm/Support/Debug.h" #include "llvm/Support/Error.h" @@ -54,18 +55,18 @@ using namespace cl; // namespace llvm { namespace cl { -template class basic_parser<bool>; -template class basic_parser<boolOrDefault>; -template class basic_parser<int>; -template class basic_parser<long>; -template class basic_parser<long long>; -template class basic_parser<unsigned>; -template class basic_parser<unsigned long>; -template class basic_parser<unsigned long long>; -template class basic_parser<double>; -template class basic_parser<float>; -template class basic_parser<std::string>; -template class basic_parser<char>; +template class LLVM_EXPORT_TEMPLATE basic_parser<bool>; +template class LLVM_EXPORT_TEMPLATE basic_parser<boolOrDefault>; +template class LLVM_EXPORT_TEMPLATE basic_parser<int>; +template class LLVM_EXPORT_TEMPLATE basic_parser<long>; +template class LLVM_EXPORT_TEMPLATE basic_parser<long long>; +template class LLVM_EXPORT_TEMPLATE basic_parser<unsigned>; +template class LLVM_EXPORT_TEMPLATE basic_parser<unsigned long>; +template class LLVM_EXPORT_TEMPLATE basic_parser<unsigned long long>; +template class LLVM_EXPORT_TEMPLATE basic_parser<double>; +template class LLVM_EXPORT_TEMPLATE basic_parser<float>; +template class LLVM_EXPORT_TEMPLATE basic_parser<std::string>; +template class LLVM_EXPORT_TEMPLATE basic_parser<char>; template class opt<unsigned>; template class opt<int>; |