diff options
author | Fangrui Song <i@maskray.me> | 2021-03-18 16:46:04 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2021-03-18 16:46:04 -0700 |
commit | 9558456b5370e64560e76f6580b979fccadd4744 (patch) | |
tree | c5d4eb9f9d38b52d6da0557b9cb0351d5dda41fc /llvm/lib/ProfileData/SampleProfReader.cpp | |
parent | c9861f722e375c419a07bcb70c54fe1384cd2999 (diff) | |
download | llvm-9558456b5370e64560e76f6580b979fccadd4744.zip llvm-9558456b5370e64560e76f6580b979fccadd4744.tar.gz llvm-9558456b5370e64560e76f6580b979fccadd4744.tar.bz2 |
[SanitizerCoverage] Make __start_/__stop_ symbols extern_weak
On ELF, we place the metadata sections (`__sancov_guards`, `__sancov_cntrs`,
`__sancov_bools`, `__sancov_pcs` in section groups (either `comdat any` or
`comdat noduplicates`).
With `--gc-sections`, LLD since D96753 and GNU ld `-z start-stop-gc` may garbage
collect such sections. If all `__sancov_bools` are discarded, LLD will error
`error: undefined hidden symbol: __start___sancov_cntrs` (other sections are similar).
```
% cat a.c
void discarded() {}
% clang -fsanitize-coverage=func,trace-pc-guard -fpic -fvisibility=hidden a.c -shared -fuse-ld=lld -Wl,--gc-sections
...
ld.lld: error: undefined hidden symbol: __start___sancov_guards
>>> referenced by a.c
>>> /tmp/a-456662.o:(sancov.module_ctor_trace_pc_guard)
```
Use the `extern_weak` linkage (lowered to undefined weak symbols) to avoid the
undefined error.
Differential Revision: https://reviews.llvm.org/D98903
Diffstat (limited to 'llvm/lib/ProfileData/SampleProfReader.cpp')
0 files changed, 0 insertions, 0 deletions