aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
diff options
context:
space:
mode:
authorKadir Cetinkaya <kadircet@google.com>2023-09-05 09:33:54 +0200
committerKadir Cetinkaya <kadircet@google.com>2023-09-06 14:46:33 +0200
commit73b2c86d95dc510d6972aaa4b44688aebebd89f1 (patch)
treeabaf16c11a530a976ab622952c543c00e0d6c125 /llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
parentb93d2d37e70942c951055019428708982b4e8d72 (diff)
downloadllvm-73b2c86d95dc510d6972aaa4b44688aebebd89f1.zip
llvm-73b2c86d95dc510d6972aaa4b44688aebebd89f1.tar.gz
llvm-73b2c86d95dc510d6972aaa4b44688aebebd89f1.tar.bz2
[include-cleaner] Weaken signal for boosting preferred headers
Putting preferred header signal above completeness implied we would uprank forward declarations above complete ones in certain cases. This can be desired in cases where: - Complete definition is private. But this case is already governed by publicness signal. - The library indeed intends to provide a forward declaring interface, like iosfwd vs ostream. In all other cases, upranking is undesired as it means we've picked up prefered headerness signal by mistake from an unrelated declaration to the library. This change regresses the behavior for libraries that intentionally provide a forward declaring interface. But that wasn't something we intended to support explicitly, it was working incidentally when the forward declaring header had a similar name to the symbol. Moreover, include-cleaner deliberately discourages forward-declarations, so not working in this case is also more aligned with rest of the components. Differential Revision: https://reviews.llvm.org/D159441
Diffstat (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp')
0 files changed, 0 insertions, 0 deletions