aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
diff options
context:
space:
mode:
authorAlexei Starovoitov <alexei.starovoitov@gmail.com>2017-04-13 22:24:13 +0000
committerAlexei Starovoitov <alexei.starovoitov@gmail.com>2017-04-13 22:24:13 +0000
commit56db14516450f980e69034f7d8a7be1e1f133c52 (patch)
treef1bfc66959ebdc5a60b7b5407349684f6129727d /llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
parente6185b70e93b16350b3cc4e82e2a809ce41dcd9b (diff)
downloadllvm-56db14516450f980e69034f7d8a7be1e1f133c52.zip
llvm-56db14516450f980e69034f7d8a7be1e1f133c52.tar.gz
llvm-56db14516450f980e69034f7d8a7be1e1f133c52.tar.bz2
[bpf] Fix memory offset check for loads and stores
If the offset cannot fit into the instruction, an addition to the pointer is emitted before the actual access. However, BPF offsets are 16-bit but LLVM considers them to be, for the matter of this check, to be 32-bit long. This causes the following program: int bpf_prog1(void *ign) { volatile unsigned long t = 0x8983984739ull; return *(unsigned long *)((0xffffffff8fff0002ull) + t); } To generate the following (wrong) code: 0: 18 01 00 00 39 47 98 83 00 00 00 00 89 00 00 00 r1 = 590618314553ll 2: 7b 1a f8 ff 00 00 00 00 *(u64 *)(r10 - 8) = r1 3: 79 a1 f8 ff 00 00 00 00 r1 = *(u64 *)(r10 - 8) 4: 79 10 02 00 00 00 00 00 r0 = *(u64 *)(r1 + 2) 5: 95 00 00 00 00 00 00 00 exit Fix it by changing the offset check to 16-bit. Patch by Nadav Amit <nadav.amit@gmail.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Differential Revision: https://reviews.llvm.org/D32055 llvm-svn: 300269
Diffstat (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp')
0 files changed, 0 insertions, 0 deletions