diff options
author | Vedant Kumar <vsk@apple.com> | 2020-10-13 16:32:31 -0700 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2020-10-13 16:32:31 -0700 |
commit | 10b6d0901f70738037e3f23e5b441be7ecb94d65 (patch) | |
tree | 3dacc34a25424df8ce9d1102a57586b51c12c677 /llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp | |
parent | b81d4bfb44c14575130bb06c047728b69c3213aa (diff) | |
download | llvm-10b6d0901f70738037e3f23e5b441be7ecb94d65.zip llvm-10b6d0901f70738037e3f23e5b441be7ecb94d65.tar.gz llvm-10b6d0901f70738037e3f23e5b441be7ecb94d65.tar.bz2 |
Revert "[llvm-cov] Warn when -arch spec is missing/invalid for universal binary"
This reverts commit b81d4bfb44c14575130bb06c047728b69c3213aa.
It's causing some bots to fail to build due to: "error: no matching
function for call to ‘__iterator_category".
Diffstat (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp')
-rw-r--r-- | llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp index c110ab7..b75738b 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp @@ -950,18 +950,6 @@ loadBinaryFormat(std::unique_ptr<Binary> Bin, StringRef Arch) { BytesInAddress, Endian); } -/// Determine whether \p Arch is invalid or empty, given \p Bin. -static bool isArchSpecifierInvalidOrMissing(Binary *Bin, StringRef Arch) { - // If we have a universal binary and Arch doesn't identify any of its slices, - // it's user error. - if (auto *Universal = dyn_cast<MachOUniversalBinary>(Bin)) - return none_of(Universal->objects(), - [Arch](const MachOUniversalBinary::ObjectForArch &Obj) { - return Obj.getArchFlagName() == Arch; - }); - return false; -} - Expected<std::vector<std::unique_ptr<BinaryCoverageReader>>> BinaryCoverageReader::create( MemoryBufferRef ObjectBuffer, StringRef Arch, @@ -982,10 +970,6 @@ BinaryCoverageReader::create( return BinOrErr.takeError(); std::unique_ptr<Binary> Bin = std::move(BinOrErr.get()); - if (isArchSpecifierInvalidOrMissing(Bin.get(), Arch)) - return make_error<CoverageMapError>( - coveragemap_error::invalid_or_missing_arch_specifier); - // MachO universal binaries which contain archives need to be treated as // archives, not as regular binaries. if (auto *Universal = dyn_cast<MachOUniversalBinary>(Bin.get())) { |