diff options
| author | Andrzej Warzynski <andrzej.warzynski@arm.com> | 2021-08-05 11:42:30 +0000 |
|---|---|---|
| committer | Andrzej Warzynski <andrzej.warzynski@arm.com> | 2021-08-19 09:30:15 +0000 |
| commit | dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b (patch) | |
| tree | ed2da2f046028b53b2d9daf6c7dce23bfae042dd /llvm/lib/Option/OptTable.cpp | |
| parent | cc3affd8b02091bf475f9dd083802e1b6a232be1 (diff) | |
| download | llvm-dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b.zip llvm-dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b.tar.gz llvm-dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b.tar.bz2 | |
[OptTable] Refine how `printHelp` treats empty help texts
Currently, `printHelp` behaves differently for options that:
* do not define `HelpText` (such options _are not printed_), and
* define its `HelpText` as `HelpText<"">` (such options _are printed_).
In practice, both approaches lead to no help text and `printHelp` should
treat them consistently. This patch addresses that by making
`printHelpt` check the length of the help text to be printed.
All affected tests have been updated accordingly. The option definitions
for llvm-cvtres have been updated with a short description or "Not
implemented" for options that are ignored by the tool.
Differential Revision: https://reviews.llvm.org/D107557
Diffstat (limited to 'llvm/lib/Option/OptTable.cpp')
| -rw-r--r-- | llvm/lib/Option/OptTable.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Option/OptTable.cpp b/llvm/lib/Option/OptTable.cpp index f5bf166..a994a42 100644 --- a/llvm/lib/Option/OptTable.cpp +++ b/llvm/lib/Option/OptTable.cpp @@ -654,7 +654,7 @@ void OptTable::printHelp(raw_ostream &OS, const char *Usage, const char *Title, HelpText = getOptionHelpText(Alias.getID()); } - if (HelpText) { + if (HelpText && (strlen(HelpText) != 0)) { const char *HelpGroup = getOptionHelpGroup(*this, Id); const std::string &OptName = getOptionHelpName(*this, Id); GroupedOptionHelp[HelpGroup].push_back({OptName, HelpText}); |