aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Object/XCOFFObjectFile.cpp
diff options
context:
space:
mode:
authorLouis Dionne <ldionne@apple.com>2020-03-27 10:04:13 -0400
committerLouis Dionne <ldionne@apple.com>2020-03-27 10:27:38 -0400
commit08776defa583676ac5c19451c6fb4fc184ee16ab (patch)
treea785952849b09553f58915bcb7020a85148018f6 /llvm/lib/Object/XCOFFObjectFile.cpp
parent848112cca4e0d173d371271015fd16b998b94e56 (diff)
downloadllvm-08776defa583676ac5c19451c6fb4fc184ee16ab.zip
llvm-08776defa583676ac5c19451c6fb4fc184ee16ab.tar.gz
llvm-08776defa583676ac5c19451c6fb4fc184ee16ab.tar.bz2
[libc++/libc++abi] Properly delimit lit substitutions
lit is not very clever when it performs substitution on RUN lines. It simply looks for a match anywhere in the line (without tokenization) and replaces it by the expansion. This means that a RUN line containing e.g. `-verify-ignore-unexpected=note` wouod be expanded to `-verify-ignore-unexpected=<substitution for not>e`, which is surprising and nonsensical. It also means that something like `%compile_module` could be expanded to `<substitution-for-%compile>_module` or to the correct substitution, depending on the order in which substitutions are evaluated by lit. To avoid such problems, it is a good habit to delimit custom substitutions with some token. This commit does that for all substitutions used in the libc++ and libc++abi test suites.
Diffstat (limited to 'llvm/lib/Object/XCOFFObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions