diff options
| author | Alex Lorenz <arphaman@gmail.com> | 2019-08-21 21:37:09 +0000 |
|---|---|---|
| committer | Alex Lorenz <arphaman@gmail.com> | 2019-08-21 21:37:09 +0000 |
| commit | 06abd696954153b7de9ffaa0c04800f5f35ed49e (patch) | |
| tree | abd86a6af55855c5066abcf572521d519b0cb99f /llvm/lib/Object/TapiFile.cpp | |
| parent | f79f594bd25995517ab9f84b662caca5b65f2413 (diff) | |
| download | llvm-06abd696954153b7de9ffaa0c04800f5f35ed49e.zip llvm-06abd696954153b7de9ffaa0c04800f5f35ed49e.tar.gz llvm-06abd696954153b7de9ffaa0c04800f5f35ed49e.tar.bz2 | |
NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken
I noticed that SourceManager::translateFile has code that doesn't really make sense.
In particular, if it fails to find a FileID by comparing FileEntry * values, it tries to
look through files that have the same filename, to see if they have a matching inode to try to
find the right FileID. However, the inode comparison seem redundant, as Clang's FileManager
already deduplicates FileEntry * values by inode.
Thus the comparisons between inodes should never actually succeed, and the comparison between FileEntry * values should be sufficient here.
Differential Revision: https://reviews.llvm.org/D65481
llvm-svn: 369585
Diffstat (limited to 'llvm/lib/Object/TapiFile.cpp')
0 files changed, 0 insertions, 0 deletions