diff options
author | Kazu Hirata <kazu@google.com> | 2024-05-08 10:33:53 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-08 10:33:53 -0700 |
commit | bb6df0804ba0a0b0581aec4156138f5144dbcee2 (patch) | |
tree | 9f1bf9618fd27b9941c88b59f5790dc9049eda7f /llvm/lib/Object/MachOObjectFile.cpp | |
parent | 46435ac19e09039fb146fa6c12da0e640a66d435 (diff) | |
download | llvm-bb6df0804ba0a0b0581aec4156138f5144dbcee2.zip llvm-bb6df0804ba0a0b0581aec4156138f5144dbcee2.tar.gz llvm-bb6df0804ba0a0b0581aec4156138f5144dbcee2.tar.bz2 |
[llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (#91441)
I'm planning to remove StringRef::equals in favor of
StringRef::operator==.
- StringRef::operator==/!= outnumber StringRef::equals by a factor of
70 under llvm/ in terms of their usage.
- The elimination of StringRef::equals brings StringRef closer to
std::string_view, which has operator== but not equals.
- S == "foo" is more readable than S.equals("foo"), especially for
!Long.Expression.equals("str") vs Long.Expression != "str".
Diffstat (limited to 'llvm/lib/Object/MachOObjectFile.cpp')
-rw-r--r-- | llvm/lib/Object/MachOObjectFile.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index 1cfd0a0..06186ad 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -399,7 +399,7 @@ static Error parseSegmentLoadCommand( return malformedError("load command " + Twine(LoadCommandIndex) + " filesize field in " + CmdName + " greater than vmsize field"); - IsPageZeroSegment |= StringRef("__PAGEZERO").equals(S.segname); + IsPageZeroSegment |= StringRef("__PAGEZERO") == S.segname; } else return SegOrErr.takeError(); @@ -4364,7 +4364,7 @@ BindRebaseSegInfo::BindRebaseSegInfo(const object::MachOObjectFile *Obj) { Info.Size = Section.getSize(); Info.SegmentName = Obj->getSectionFinalSegmentName(Section.getRawDataRefImpl()); - if (!Info.SegmentName.equals(CurSegName)) { + if (Info.SegmentName != CurSegName) { ++CurSegIndex; CurSegName = Info.SegmentName; CurSegAddress = Info.Address; |