diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2021-09-17 17:47:28 +0100 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2021-09-20 12:53:18 +0100 |
| commit | 7fc12b822c5d1360780667af94c218733c3fc4e0 (patch) | |
| tree | 1d27a40f5d4a1ca281838659bbcf908d1a4e2a48 /llvm/lib/Object/MachOObjectFile.cpp | |
| parent | 4ab7c0d3fa068fb0ce39b9f75c0253d45a99745e (diff) | |
| download | llvm-7fc12b822c5d1360780667af94c218733c3fc4e0.zip llvm-7fc12b822c5d1360780667af94c218733c3fc4e0.tar.gz llvm-7fc12b822c5d1360780667af94c218733c3fc4e0.tar.bz2 | |
MachOObjectFile - checkOverlappingElement - use const-ref to avoid unnecessary copies. NFCI.
Reported by MSVC static analyzer.
Diffstat (limited to 'llvm/lib/Object/MachOObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/MachOObjectFile.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index 177314a..e84defb 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -246,8 +246,8 @@ static Error checkOverlappingElement(std::list<MachOElement> &Elements, if (Size == 0) return Error::success(); - for (auto it=Elements.begin() ; it != Elements.end(); ++it) { - auto E = *it; + for (auto it = Elements.begin(); it != Elements.end(); ++it) { + const auto &E = *it; if ((Offset >= E.Offset && Offset < E.Offset + E.Size) || (Offset + Size > E.Offset && Offset + Size < E.Offset + E.Size) || (Offset <= E.Offset && Offset + Size >= E.Offset + E.Size)) @@ -258,7 +258,7 @@ static Error checkOverlappingElement(std::list<MachOElement> &Elements, auto nt = it; nt++; if (nt != Elements.end()) { - auto N = *nt; + const auto &N = *nt; if (Offset + Size <= N.Offset) { Elements.insert(nt, {Offset, Size, Name}); return Error::success(); |