aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Object/MachOObjectFile.cpp
diff options
context:
space:
mode:
authorStephane Moore <mog@google.com>2019-03-20 23:05:00 +0000
committerStephane Moore <mog@google.com>2019-03-20 23:05:00 +0000
commit5f70c473c9c0c7a7911534c7826e01c1c632c3cd (patch)
tree7cfb5abff9c7a35ebf3584716b8955d3dc634b76 /llvm/lib/Object/MachOObjectFile.cpp
parent9d760a0a76e6caec6f675bf2633c5aa7fab00f71 (diff)
downloadllvm-5f70c473c9c0c7a7911534c7826e01c1c632c3cd.zip
llvm-5f70c473c9c0c7a7911534c7826e01c1c632c3cd.tar.gz
llvm-5f70c473c9c0c7a7911534c7826e01c1c632c3cd.tar.bz2
[clang-tidy] Disable google-runtime-int in Objective-C++ 🔓
Summary: In contrast to Google C++, Objective-C often uses built-in integer types other than `int`. In fact, the Objective-C runtime itself defines the types NSInteger¹ and NSUInteger² which are variant types depending on the target architecture. The Objective-C style guide indicates that usage of system types with variant sizes is appropriate when handling values provided by system interfaces³. Objective-C++ is commonly the result of conversion from Objective-C to Objective-C++ for the purpose of integrating C++ functionality. The opposite of Objective-C++ being used to expose Objective-C functionality to C++ is less common, potentially because Objective-C has a signficantly more uneven presence on different platforms compared to C++. This generally predisposes Objective-C++ to commonly being more Objective-C than C++. Forcing Objective-C++ developers to perform conversions between variant system types and fixed size integer types depending on target architecture when Objective-C++ commonly uses variant system types from Objective-C is likely to lead to more bugs and overhead than benefit. For that reason, this change proposes to disable google-runtime-int in Objective-C++. [1] https://developer.apple.com/documentation/objectivec/nsinteger?language=objc [2] https://developer.apple.com/documentation/objectivec/nsuinteger?language=objc [3] "Types long, NSInteger, NSUInteger, and CGFloat vary in size between 32- and 64-bit builds. Use of these types is appropriate when handling values exposed by system interfaces, but they should be avoided for most other computations." https://github.com/google/styleguide/blob/gh-pages/objcguide.md#types-with-inconsistent-sizes Subscribers: xazax.hun, jdoerfert, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D59336 llvm-svn: 356627
Diffstat (limited to 'llvm/lib/Object/MachOObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions