diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2023-03-24 17:34:14 -0700 |
|---|---|---|
| committer | Shoaib Meenai <smeenai@fb.com> | 2023-03-25 21:37:42 -0700 |
| commit | 377e1311d50c7e5b5aab3db081938e0d0ceebdfc (patch) | |
| tree | 42695adc7a9504adff62416306a1a19664de54f4 /llvm/lib/Object/ELFObjectFile.cpp | |
| parent | 943df86c82b1450bde45678757b7c39e459bc6ad (diff) | |
| download | llvm-377e1311d50c7e5b5aab3db081938e0d0ceebdfc.zip llvm-377e1311d50c7e5b5aab3db081938e0d0ceebdfc.tar.gz llvm-377e1311d50c7e5b5aab3db081938e0d0ceebdfc.tar.bz2 | |
[ThinLTO] Only import for non-prevailing interposable global variables
This logic was added in https://reviews.llvm.org/D95943 specifically to
handle an issue for non-prevailing global variables. It turns out that
it adds a new issue for prevailing glboal variables, since those could
be replaced by an available_externally definition and hence incorrectly
omitted from the output object file. Limit the import to non-prevailing
global variables to fix this, as suggested by @tejohnson.
The bulk of the diff is mechanical changes to thread isPrevailing
through to where it's needed and ensure it's available before the
relevant calls; the actual logic change itself is straightforward.
Fixes https://github.com/llvm/llvm-project/issues/61677
Reviewed By: tejohnson
Differential Revision: https://reviews.llvm.org/D146876
Diffstat (limited to 'llvm/lib/Object/ELFObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions