diff options
| author | Peter Collingbourne <peter@pcc.me.uk> | 2015-08-06 05:26:35 +0000 |
|---|---|---|
| committer | Peter Collingbourne <peter@pcc.me.uk> | 2015-08-06 05:26:35 +0000 |
| commit | e834f4207320f4a0eb809e3d7494c8055c668cb3 (patch) | |
| tree | 432b271104a777f95129b6f402e700a6bbda6590 /llvm/lib/Object/COFFObjectFile.cpp | |
| parent | 4cb29abcdbffd3e3df7c9ef7ba4a87fa713d0160 (diff) | |
| download | llvm-e834f4207320f4a0eb809e3d7494c8055c668cb3.zip llvm-e834f4207320f4a0eb809e3d7494c8055c668cb3.tar.gz llvm-e834f4207320f4a0eb809e3d7494c8055c668cb3.tar.bz2 | |
COFF: Assign the correct symbol type to internal functions.
The COFFSymbolRef::isFunctionDefinition() function tests for several conditions
that are not related to whether a symbol is a function, but rather whether
the symbol meets the requirements for a function definition auxiliary record,
which excludes certain symbols such as internal functions and undefined
references. The test we need to determine the symbol type is much simpler:
we only need to compare the complex type against IMAGE_SYM_DTYPE_FUNCTION.
llvm-svn: 244195
Diffstat (limited to 'llvm/lib/Object/COFFObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/COFFObjectFile.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Object/COFFObjectFile.cpp b/llvm/lib/Object/COFFObjectFile.cpp index d110b92..fa6aa4c 100644 --- a/llvm/lib/Object/COFFObjectFile.cpp +++ b/llvm/lib/Object/COFFObjectFile.cpp @@ -186,10 +186,10 @@ SymbolRef::Type COFFObjectFile::getSymbolType(DataRefImpl Ref) const { COFFSymbolRef Symb = getCOFFSymbol(Ref); int32_t SectionNumber = Symb.getSectionNumber(); + if (Symb.getComplexType() == COFF::IMAGE_SYM_DTYPE_FUNCTION) + return SymbolRef::ST_Function; if (Symb.isAnyUndefined()) return SymbolRef::ST_Unknown; - if (Symb.isFunctionDefinition()) - return SymbolRef::ST_Function; if (Symb.isCommon()) return SymbolRef::ST_Data; if (Symb.isFileRecord()) |