diff options
| author | vgxbj <higuoxing@gmail.com> | 2020-04-10 20:24:21 +0800 |
|---|---|---|
| committer | vgxbj <higuoxing@gmail.com> | 2020-04-18 21:27:57 +0800 |
| commit | ac00376a13e9b637a8bc6b9e2ae6fd668e01b0f9 (patch) | |
| tree | 6962508217cdaf939712e44cfbaff1a091cfd32f /llvm/lib/Object/ArchiveWriter.cpp | |
| parent | 9cd68bfa0e49f755a0cc90b27025fa2e48083050 (diff) | |
| download | llvm-ac00376a13e9b637a8bc6b9e2ae6fd668e01b0f9.zip llvm-ac00376a13e9b637a8bc6b9e2ae6fd668e01b0f9.tar.gz llvm-ac00376a13e9b637a8bc6b9e2ae6fd668e01b0f9.tar.bz2 | |
[Object] Change uint32_t getSymbolFlags() to Expected<uint32_t> getSymbolFlags().
This change enables getSymbolFlags() to return errors which benefit error reporting in clients.
Differential Revision: https://reviews.llvm.org/D77860
Diffstat (limited to 'llvm/lib/Object/ArchiveWriter.cpp')
| -rw-r--r-- | llvm/lib/Object/ArchiveWriter.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/llvm/lib/Object/ArchiveWriter.cpp b/llvm/lib/Object/ArchiveWriter.cpp index 7e3416f..6f92c54 100644 --- a/llvm/lib/Object/ArchiveWriter.cpp +++ b/llvm/lib/Object/ArchiveWriter.cpp @@ -264,12 +264,15 @@ static sys::TimePoint<std::chrono::seconds> now(bool Deterministic) { } static bool isArchiveSymbol(const object::BasicSymbolRef &S) { - uint32_t Symflags = S.getFlags(); - if (Symflags & object::SymbolRef::SF_FormatSpecific) + Expected<uint32_t> SymFlagsOrErr = S.getFlags(); + if (!SymFlagsOrErr) + // TODO: Actually report errors helpfully. + report_fatal_error(SymFlagsOrErr.takeError()); + if (*SymFlagsOrErr & object::SymbolRef::SF_FormatSpecific) return false; - if (!(Symflags & object::SymbolRef::SF_Global)) + if (!(*SymFlagsOrErr & object::SymbolRef::SF_Global)) return false; - if (Symflags & object::SymbolRef::SF_Undefined) + if (*SymFlagsOrErr & object::SymbolRef::SF_Undefined) return false; return true; } |