diff options
| author | Jacek Caban <jacek@codeweavers.com> | 2023-04-21 23:47:55 +0000 |
|---|---|---|
| committer | Thurston Dang <thurston@google.com> | 2023-04-22 00:04:30 +0000 |
| commit | ebee5e0473df7685086eb2f4ffb07e1bf965b3bd (patch) | |
| tree | 8acf726056c34431337c9808545c25ee0b21d1ed /llvm/lib/Object/Archive.cpp | |
| parent | 1a3f158add6099914f943ac87fb3b0b8738f8ec8 (diff) | |
| download | llvm-ebee5e0473df7685086eb2f4ffb07e1bf965b3bd.zip llvm-ebee5e0473df7685086eb2f4ffb07e1bf965b3bd.tar.gz llvm-ebee5e0473df7685086eb2f4ffb07e1bf965b3bd.tar.bz2 | |
[Object] Always initialized StartOfFile in Archive::Child::Child constructor.
Fixes uninitialized memory access revealed by https://reviews.llvm.org/D146534.
In empty archives, we use Child(nullptr,nullptr,nullptr) in Archive constructor in setFirstRegular. This copies unitialized StartOfFile to FirstRegularStartOfFile, which child_begin may use later.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D148955
Diffstat (limited to 'llvm/lib/Object/Archive.cpp')
| -rw-r--r-- | llvm/lib/Object/Archive.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp index 6ddbe35..081ff79 100644 --- a/llvm/lib/Object/Archive.cpp +++ b/llvm/lib/Object/Archive.cpp @@ -468,6 +468,7 @@ Archive::Child::Child(const Archive *Parent, const char *Start, Error *Err) : Parent(Parent) { if (!Start) { Header = nullptr; + StartOfFile = -1; return; } |