diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2020-01-28 20:23:46 +0100 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2020-01-28 23:25:25 +0100 |
| commit | adcd02683856c30ba6f349279509acecd90063df (patch) | |
| tree | 7b5927ef2ecab1618842183fac5ebe848f5832dd /llvm/lib/MC/SubtargetFeature.cpp | |
| parent | 5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0 (diff) | |
| download | llvm-adcd02683856c30ba6f349279509acecd90063df.zip llvm-adcd02683856c30ba6f349279509acecd90063df.tar.gz llvm-adcd02683856c30ba6f349279509acecd90063df.tar.bz2 | |
Make llvm::StringRef to std::string conversions explicit.
This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.
This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.
This doesn't actually modify StringRef yet, I'll do that in a follow-up.
Diffstat (limited to 'llvm/lib/MC/SubtargetFeature.cpp')
| -rw-r--r-- | llvm/lib/MC/SubtargetFeature.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/MC/SubtargetFeature.cpp b/llvm/lib/MC/SubtargetFeature.cpp index c4dd773..3155adc 100644 --- a/llvm/lib/MC/SubtargetFeature.cpp +++ b/llvm/lib/MC/SubtargetFeature.cpp @@ -33,7 +33,9 @@ using namespace llvm; void SubtargetFeatures::Split(std::vector<std::string> &V, StringRef S) { SmallVector<StringRef, 3> Tmp; S.split(Tmp, ',', -1, false /* KeepEmpty */); - V.assign(Tmp.begin(), Tmp.end()); + V.reserve(Tmp.size()); + for (StringRef T : Tmp) + V.push_back(std::string(T)); } void SubtargetFeatures::AddFeature(StringRef String, bool Enable) { |