diff options
| author | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
| commit | 7ddcdc82a59e28f011fc6be6f47de948fe8f6abb (patch) | |
| tree | febdfaf4b6126826fcef7b828fe212cfdde800c3 /llvm/lib/MC/MCSymbol.cpp | |
| parent | b6c825a5cf92ca352826552d47e6d82c71eaa7f1 (diff) | |
| download | llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.zip llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.tar.gz llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.tar.bz2 | |
Revert "Re-commit r192758 - MC: quote tricky symbol names in asm output"
This caused the clang-native-mingw32-win7 buildbot to break.
The assembler was complaining about the following lines that were showing up
in the asm for CrashRecoveryContext.cpp:
movl $"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4", 4(%eax)
calll "_AddVectoredExceptionHandler@8"
.def "__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4";
"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4":
calll "_RemoveVectoredExceptionHandler@4"
Reverting for now.
llvm-svn: 192940
Diffstat (limited to 'llvm/lib/MC/MCSymbol.cpp')
| -rw-r--r-- | llvm/lib/MC/MCSymbol.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/llvm/lib/MC/MCSymbol.cpp b/llvm/lib/MC/MCSymbol.cpp index f386c3b..b973c57 100644 --- a/llvm/lib/MC/MCSymbol.cpp +++ b/llvm/lib/MC/MCSymbol.cpp @@ -18,10 +18,12 @@ const MCSection *MCSymbol::AbsolutePseudoSection = reinterpret_cast<const MCSection *>(1); static bool isAcceptableChar(char C) { - return (C >= 'a' && C <= 'z') || - (C >= 'A' && C <= 'Z') || - (C >= '0' && C <= '9') || - C == '_' || C == '$' || C == '.'; + if ((C < 'a' || C > 'z') && + (C < 'A' || C > 'Z') && + (C < '0' || C > '9') && + C != '_' && C != '$' && C != '.' && C != '@') + return false; + return true; } /// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be |