diff options
| author | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
| commit | 7ddcdc82a59e28f011fc6be6f47de948fe8f6abb (patch) | |
| tree | febdfaf4b6126826fcef7b828fe212cfdde800c3 /llvm/lib/MC/MCSectionCOFF.cpp | |
| parent | b6c825a5cf92ca352826552d47e6d82c71eaa7f1 (diff) | |
| download | llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.zip llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.tar.gz llvm-7ddcdc82a59e28f011fc6be6f47de948fe8f6abb.tar.bz2 | |
Revert "Re-commit r192758 - MC: quote tricky symbol names in asm output"
This caused the clang-native-mingw32-win7 buildbot to break.
The assembler was complaining about the following lines that were showing up
in the asm for CrashRecoveryContext.cpp:
movl $"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4", 4(%eax)
calll "_AddVectoredExceptionHandler@8"
.def "__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4";
"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4":
calll "_RemoveVectoredExceptionHandler@4"
Reverting for now.
llvm-svn: 192940
Diffstat (limited to 'llvm/lib/MC/MCSectionCOFF.cpp')
| -rw-r--r-- | llvm/lib/MC/MCSectionCOFF.cpp | 21 |
1 files changed, 1 insertions, 20 deletions
diff --git a/llvm/lib/MC/MCSectionCOFF.cpp b/llvm/lib/MC/MCSectionCOFF.cpp index a8f5db0..64aa2c5 100644 --- a/llvm/lib/MC/MCSectionCOFF.cpp +++ b/llvm/lib/MC/MCSectionCOFF.cpp @@ -39,22 +39,6 @@ void MCSectionCOFF::setSelection(int Selection, Characteristics |= COFF::IMAGE_SCN_LNK_COMDAT; } -static bool isAcceptableSectionNameChar(char C) { - return (C >= 'a' && C <= 'z') || - (C >= 'A' && C <= 'Z') || - (C >= '0' && C <= '9') || - C == '_' || C == '$' || C == '.'; -} - -/// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be -/// syntactically correct. -static bool sectionNameNeedsQuoting(StringRef Name) { - for (unsigned i = 0, e = Name.size(); i != e; ++i) - if (!isAcceptableSectionNameChar(Name[i])) - return true; - return false; -} - void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, raw_ostream &OS, const MCExpr *Subsection) const { @@ -65,10 +49,7 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, return; } - if (sectionNameNeedsQuoting(getSectionName())) - OS << "\t.section\t" << '"' << getSectionName() << '"' << ",\""; - else - OS << "\t.section\t" << getSectionName() << ",\""; + OS << "\t.section\t" << getSectionName() << ",\""; if (getKind().isText()) OS << 'x'; if (getKind().isWriteable()) |