diff options
| author | Hans Wennborg <hans@chromium.org> | 2020-11-11 15:55:52 +0100 |
|---|---|---|
| committer | Hans Wennborg <hans@chromium.org> | 2020-11-11 16:03:33 +0100 |
| commit | 418f18c6cdfe56e77669e2f4d3df3bca1020156d (patch) | |
| tree | 14fbf26f80be8eeedda00f5b052d15e8bb1c836b /llvm/lib/MC/MCObjectFileInfo.cpp | |
| parent | 138189ee33ab4359bbda834d8715b16d096c1087 (diff) | |
| download | llvm-418f18c6cdfe56e77669e2f4d3df3bca1020156d.zip llvm-418f18c6cdfe56e77669e2f4d3df3bca1020156d.tar.gz llvm-418f18c6cdfe56e77669e2f4d3df3bca1020156d.tar.bz2 | |
Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support"
This broke both Firefox and Chromium (PR47905) due to what seems like dllimport
function not being handled correctly.
> This patch adds support for creating Guard Address-Taken IAT Entry Tables (.giats$y sections) in object files, matching the behavior of MSVC. These contain lists of address-taken imported functions, which are used by the linker to create the final GIATS table.
> Additionally, if any DLLs are delay-loaded, the linker must look through the .giats tables and add the respective load thunks of address-taken imports to the GFIDS table, as these are also valid call targets.
>
> Reviewed By: rnk
>
> Differential Revision: https://reviews.llvm.org/D87544
This reverts commit cfd8481da1adba1952e0f6ecd00440986e49a946.
Diffstat (limited to 'llvm/lib/MC/MCObjectFileInfo.cpp')
| -rw-r--r-- | llvm/lib/MC/MCObjectFileInfo.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp index b8c66c6..6632220 100644 --- a/llvm/lib/MC/MCObjectFileInfo.cpp +++ b/llvm/lib/MC/MCObjectFileInfo.cpp @@ -754,11 +754,6 @@ void MCObjectFileInfo::initCOFFMCObjectFileInfo(const Triple &T) { COFF::IMAGE_SCN_MEM_READ, SectionKind::getMetadata()); - GIATsSection = Ctx->getCOFFSection(".giats$y", - COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | - COFF::IMAGE_SCN_MEM_READ, - SectionKind::getMetadata()); - GLJMPSection = Ctx->getCOFFSection(".gljmp$y", COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | COFF::IMAGE_SCN_MEM_READ, |