diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-12-17 15:08:24 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-12-17 15:08:24 +0000 |
commit | d0e16522c7b7cd09a656976206a0b02da8955182 (patch) | |
tree | 480e837758d4f346e51080d7a7baa02a655214ad /llvm/lib/MC/MCELFObjectTargetWriter.cpp | |
parent | 8561841875686e6fd165474db3ecb6965f535a6d (diff) | |
download | llvm-d0e16522c7b7cd09a656976206a0b02da8955182.zip llvm-d0e16522c7b7cd09a656976206a0b02da8955182.tar.gz llvm-d0e16522c7b7cd09a656976206a0b02da8955182.tar.bz2 |
Always sort by offset first. NFC.
Every target changing sortRelocs was first calling the parent
implementation. Just run that first.
llvm-svn: 255898
Diffstat (limited to 'llvm/lib/MC/MCELFObjectTargetWriter.cpp')
-rw-r--r-- | llvm/lib/MC/MCELFObjectTargetWriter.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/llvm/lib/MC/MCELFObjectTargetWriter.cpp b/llvm/lib/MC/MCELFObjectTargetWriter.cpp index bc0ba85..de645ca 100644 --- a/llvm/lib/MC/MCELFObjectTargetWriter.cpp +++ b/llvm/lib/MC/MCELFObjectTargetWriter.cpp @@ -29,23 +29,7 @@ bool MCELFObjectTargetWriter::needsRelocateWithSymbol(const MCSymbol &Sym, return false; } -// ELF doesn't require relocations to be in any order. We sort by the Offset, -// just to match gnu as for easier comparison. The use type is an arbitrary way -// of making the sort deterministic. -static int cmpRel(const ELFRelocationEntry *AP, const ELFRelocationEntry *BP) { - const ELFRelocationEntry &A = *AP; - const ELFRelocationEntry &B = *BP; - if (A.Offset != B.Offset) - return B.Offset - A.Offset; - if (B.Type != A.Type) - return A.Type - B.Type; - //llvm_unreachable("ELFRelocs might be unstable!"); - return 0; -} - - void MCELFObjectTargetWriter::sortRelocs(const MCAssembler &Asm, std::vector<ELFRelocationEntry> &Relocs) { - array_pod_sort(Relocs.begin(), Relocs.end(), cmpRel); } |