diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-03-06 01:57:34 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-03-06 01:57:34 +0000 |
| commit | d0bb55a1d443591e470425413bdc4212bee798b2 (patch) | |
| tree | 2a64c2d8d1e3105542aef35a9165354c3d11424f /llvm/lib/MC/MCDisassembler/Disassembler.cpp | |
| parent | cab4afd7c68c680a6b2f4a510e0264485ad8cd8f (diff) | |
| download | llvm-d0bb55a1d443591e470425413bdc4212bee798b2.zip llvm-d0bb55a1d443591e470425413bdc4212bee798b2.tar.gz llvm-d0bb55a1d443591e470425413bdc4212bee798b2.tar.bz2 | |
Use private linkage for remaining GlobalVariables with private names.
This patch changes the remaining GlobalVariables using "\01L" and
"\01l" prefixes to use private linkage. What is strange about them is
that they currently use WeakAnyLinkage. There is no comment stating
why and that is really odd since the symbols are completely hidden, so
it doesn't make sense for them to be weak.
Clang revisions like r63329, r63408, r63770, r65761 set the linkage to
weak, but don't say why. I suspect they were just copying llvm-gcc.
In llvm-gcc I found r58599 and r56322 that set DECL_WEAK, but they
were just syncing from the apple gcc. I am not exactly sure what that
means, since the last commit to
svn://gcc.gnu.org/svn/gcc/branches/apple was in 2006, 2 years earlier.
In summary, I have no idea why weak linkage was being used :-(
To quote John McCall, "Let’s try without it and see" :-)
llvm-svn: 203059
Diffstat (limited to 'llvm/lib/MC/MCDisassembler/Disassembler.cpp')
0 files changed, 0 insertions, 0 deletions