diff options
| author | Fangrui Song <i@maskray.me> | 2020-12-20 21:18:22 -0800 |
|---|---|---|
| committer | Fangrui Song <i@maskray.me> | 2020-12-20 21:18:22 -0800 |
| commit | e4c360a897fe062914519d331e8f1e28b2b1fbfd (patch) | |
| tree | 3ebe91e2793b546aca2ebc4dea4228eafdf148ad /llvm/lib/MC/ELFObjectWriter.cpp | |
| parent | 553d4d08d2bee53d2cc19ea5160a0dfbffe12fa9 (diff) | |
| download | llvm-e4c360a897fe062914519d331e8f1e28b2b1fbfd.zip llvm-e4c360a897fe062914519d331e8f1e28b2b1fbfd.tar.gz llvm-e4c360a897fe062914519d331e8f1e28b2b1fbfd.tar.bz2 | |
[MC][ELF] Drop MCSymbol::isExternal call sites
ELF uses symbol bindings and MCSymbol::isExternal is not really useful.
The function is no longer used in ELF code now.
Diffstat (limited to 'llvm/lib/MC/ELFObjectWriter.cpp')
| -rw-r--r-- | llvm/lib/MC/ELFObjectWriter.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp index d5da8de..69307b6 100644 --- a/llvm/lib/MC/ELFObjectWriter.cpp +++ b/llvm/lib/MC/ELFObjectWriter.cpp @@ -464,7 +464,7 @@ void ELFWriter::writeHeader(const MCAssembler &Asm) { uint64_t ELFWriter::SymbolValue(const MCSymbol &Sym, const MCAsmLayout &Layout) { - if (Sym.isCommon() && (Sym.isTargetCommon() || Sym.isExternal())) + if (Sym.isCommon()) return Sym.getCommonAlignment(); uint64_t Res; @@ -1278,7 +1278,6 @@ void ELFObjectWriter::executePostLayoutBinding(MCAssembler &Asm, // Aliases defined with .symvar copy the binding from the symbol they alias. // This is the first place we are able to copy this information. - Alias->setExternal(Symbol.isExternal()); Alias->setBinding(Symbol.getBinding()); Alias->setVisibility(Symbol.getVisibility()); Alias->setOther(Symbol.getOther()); |