diff options
author | Georgii Rymar <grimar@accesssoftek.com> | 2020-12-03 12:57:00 +0300 |
---|---|---|
committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-12-04 16:02:29 +0300 |
commit | ffbce65f95eea7db1ca151d38b3391b2a4f3da81 (patch) | |
tree | 355d782bed63ea1f52feed709438135296c88be1 /llvm/lib/InterfaceStub/ELFObjHandler.cpp | |
parent | e936d1e11345db5d2de3d1a73bd705d8fcf99fbc (diff) | |
download | llvm-ffbce65f95eea7db1ca151d38b3391b2a4f3da81.zip llvm-ffbce65f95eea7db1ca151d38b3391b2a4f3da81.tar.gz llvm-ffbce65f95eea7db1ca151d38b3391b2a4f3da81.tar.bz2 |
[lib/Object, tools] - Make ELFObjectFile::getELFFile return reference.
We always have an object, so we don't have to return a pointer.
Differential revision: https://reviews.llvm.org/D92560
Diffstat (limited to 'llvm/lib/InterfaceStub/ELFObjHandler.cpp')
-rw-r--r-- | llvm/lib/InterfaceStub/ELFObjHandler.cpp | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/llvm/lib/InterfaceStub/ELFObjHandler.cpp b/llvm/lib/InterfaceStub/ELFObjHandler.cpp index ba583b79..e50ebd7 100644 --- a/llvm/lib/InterfaceStub/ELFObjHandler.cpp +++ b/llvm/lib/InterfaceStub/ELFObjHandler.cpp @@ -585,15 +585,15 @@ buildStub(const ELFObjectFile<ELFT> &ElfObj) { using Elf_Sym_Range = typename ELFT::SymRange; using Elf_Sym = typename ELFT::Sym; std::unique_ptr<ELFStub> DestStub = std::make_unique<ELFStub>(); - const ELFFile<ELFT> *ElfFile = ElfObj.getELFFile(); + const ELFFile<ELFT> &ElfFile = ElfObj.getELFFile(); // Fetch .dynamic table. - Expected<Elf_Dyn_Range> DynTable = ElfFile->dynamicEntries(); + Expected<Elf_Dyn_Range> DynTable = ElfFile.dynamicEntries(); if (!DynTable) { return DynTable.takeError(); } // Fetch program headers. - Expected<Elf_Phdr_Range> PHdrs = ElfFile->program_headers(); + Expected<Elf_Phdr_Range> PHdrs = ElfFile.program_headers(); if (!PHdrs) { return PHdrs.takeError(); } @@ -604,8 +604,7 @@ buildStub(const ELFObjectFile<ELFT> &ElfObj) { return std::move(Err); // Get pointer to in-memory location of .dynstr section. - Expected<const uint8_t *> DynStrPtr = - ElfFile->toMappedAddr(DynEnt.StrTabAddr); + Expected<const uint8_t *> DynStrPtr = ElfFile.toMappedAddr(DynEnt.StrTabAddr); if (!DynStrPtr) return appendToError(DynStrPtr.takeError(), "when locating .dynstr section contents"); @@ -614,7 +613,7 @@ buildStub(const ELFObjectFile<ELFT> &ElfObj) { DynEnt.StrSize); // Populate Arch from ELF header. - DestStub->Arch = ElfFile->getHeader().e_machine; + DestStub->Arch = ElfFile.getHeader().e_machine; // Populate SoName from .dynamic entries and dynamic string table. if (DynEnt.SONameOffset.hasValue()) { @@ -637,13 +636,13 @@ buildStub(const ELFObjectFile<ELFT> &ElfObj) { } // Populate Symbols from .dynsym table and dynamic string table. - Expected<uint64_t> SymCount = getNumSyms(DynEnt, *ElfFile); + Expected<uint64_t> SymCount = getNumSyms(DynEnt, ElfFile); if (!SymCount) return SymCount.takeError(); if (*SymCount > 0) { // Get pointer to in-memory location of .dynsym section. Expected<const uint8_t *> DynSymPtr = - ElfFile->toMappedAddr(DynEnt.DynSymAddr); + ElfFile.toMappedAddr(DynEnt.DynSymAddr); if (!DynSymPtr) return appendToError(DynSymPtr.takeError(), "when locating .dynsym section contents"); |