diff options
author | Philip Reames <preames@rivosinc.com> | 2025-05-06 14:24:40 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-06 14:24:40 -0700 |
commit | 650dca5d896023c05bd34dafb756d9bdf7c0033d (patch) | |
tree | 3baf75a7c347008a3ff4c05774f6ce87621a9822 /llvm/lib/IR/Verifier.cpp | |
parent | 9d89b05f1147dc442794186f505e30a27ffe75a7 (diff) | |
download | llvm-650dca5d896023c05bd34dafb756d9bdf7c0033d.zip llvm-650dca5d896023c05bd34dafb756d9bdf7c0033d.tar.gz llvm-650dca5d896023c05bd34dafb756d9bdf7c0033d.tar.bz2 |
[IR] Remove the AtomicMem*Inst helper classes (#138710)
Migrate their usage to the `AnyMem*Inst` family, and add a isAtomic()
query on the base class for that hierarchy. This matches the idioms we
use for e.g. isAtomic on load, store, etc.. instructions, the existing
isVolatile idioms on mem* routines, and allows us to more easily share
code between atomic and non-atomic variants.
As with #138568, the goal here is to simplify the class hierarchy and
make it easier to reason about. I'm moving from easiest to hardest, and
will stop at some point when I hit "good enough". Longer term, I'd sorta
like to merge or reverse the naming on the plain Mem*Inst and the
AnyMem*Inst, but that's a much larger and more risky change. Not sure
I'm going to actually do that.
Diffstat (limited to 'llvm/lib/IR/Verifier.cpp')
-rw-r--r-- | llvm/lib/IR/Verifier.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp index a798808..83c1264 100644 --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -5617,7 +5617,7 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) { case Intrinsic::memcpy_element_unordered_atomic: case Intrinsic::memmove_element_unordered_atomic: case Intrinsic::memset_element_unordered_atomic: { - const auto *AMI = cast<AtomicMemIntrinsic>(&Call); + const auto *AMI = cast<AnyMemIntrinsic>(&Call); ConstantInt *ElementSizeCI = cast<ConstantInt>(AMI->getRawElementSizeInBytes()); @@ -5632,7 +5632,7 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) { }; Check(IsValidAlignment(AMI->getDestAlign()), "incorrect alignment of the destination argument", Call); - if (const auto *AMT = dyn_cast<AtomicMemTransferInst>(AMI)) { + if (const auto *AMT = dyn_cast<AnyMemTransferInst>(AMI)) { Check(IsValidAlignment(AMT->getSourceAlign()), "incorrect alignment of the source argument", Call); } |