diff options
author | Jeremy Morse <jeremy.morse@sony.com> | 2023-11-02 17:17:19 +0000 |
---|---|---|
committer | Jeremy Morse <jeremy.morse@sony.com> | 2023-11-02 17:41:36 +0000 |
commit | 957efa4ce4f0391147cec62746e997226ee2b836 (patch) | |
tree | 4b39d03d52aa393dc2bf64c56f3843a2d77b2d17 /llvm/lib/IR/DebugInfoMetadata.cpp | |
parent | 495ed8d8c8b3795dd51595aad7a192189f2cfeab (diff) | |
download | llvm-957efa4ce4f0391147cec62746e997226ee2b836.zip llvm-957efa4ce4f0391147cec62746e997226ee2b836.tar.gz llvm-957efa4ce4f0391147cec62746e997226ee2b836.tar.bz2 |
Revert "[DebugInfo][RemoveDIs] Add prototype storage classes for "new" debug-info"
And some intervening fixups. There are two remaining problems:
* A memory leak via https://lab.llvm.org/buildbot/#/builders/236/builds/7120/steps/10/logs/stdio
* A performance slowdown with -g where I'm not completely sure what the cause it
These might be fairly straightforwards to fix, but it's the end of the day
hear, so I figure I'll clear the buildbots til tomorrow.
This reverts commit 7d77bbef4ad9230f6f427649373fe46a668aa909.
This reverts commit 9026f35afe6ffdc5e55b6615efcbd36f25b11558.
This reverts commit d97b2b389a0e511c65af6845119eb08b8a2cb473.
Diffstat (limited to 'llvm/lib/IR/DebugInfoMetadata.cpp')
-rw-r--r-- | llvm/lib/IR/DebugInfoMetadata.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/llvm/lib/IR/DebugInfoMetadata.cpp b/llvm/lib/IR/DebugInfoMetadata.cpp index e05fd29d..f7f3612 100644 --- a/llvm/lib/IR/DebugInfoMetadata.cpp +++ b/llvm/lib/IR/DebugInfoMetadata.cpp @@ -2135,14 +2135,8 @@ void DIArgList::handleChangedOperand(void *Ref, Metadata *New) { } } if (Uniq) { - MDNode *UniqueArgList = uniquify(); - if (UniqueArgList != this) { - replaceAllUsesWith(UniqueArgList); - // Clear this here so we don't try to untrack in the destructor. - Args.clear(); - delete this; - return; - } + if (uniquify() != this) + storeDistinctInContext(); } track(); } |