diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-11-18 09:31:53 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-11-18 09:31:53 +0000 |
| commit | 49109a279c6b7b3622fa0227f6c77a96d075f718 (patch) | |
| tree | d3ee87a1f6131cd29380a4ce6dd84aa232b2fa4c /llvm/lib/IR/Attributes.cpp | |
| parent | 6588c1a638032c8146be7f5d62a125f5d89dea76 (diff) | |
| download | llvm-49109a279c6b7b3622fa0227f6c77a96d075f718.zip llvm-49109a279c6b7b3622fa0227f6c77a96d075f718.tar.gz llvm-49109a279c6b7b3622fa0227f6c77a96d075f718.tar.bz2 | |
Revert r194865 and r194874.
This change is incorrect. If you delete virtual destructor of both a base class
and a subclass, then the following code:
Base *foo = new Child();
delete foo;
will not cause the destructor for members of Child class. As a result, I observe
plently of memory leaks. Notable examples I investigated are:
ObjectBuffer and ObjectBufferStream, AttributeImpl and StringSAttributeImpl.
llvm-svn: 194997
Diffstat (limited to 'llvm/lib/IR/Attributes.cpp')
| -rw-r--r-- | llvm/lib/IR/Attributes.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/llvm/lib/IR/Attributes.cpp b/llvm/lib/IR/Attributes.cpp index f876778..bcd324c 100644 --- a/llvm/lib/IR/Attributes.cpp +++ b/llvm/lib/IR/Attributes.cpp @@ -286,6 +286,8 @@ bool Attribute::operator<(Attribute A) const { // AttributeImpl Definition //===----------------------------------------------------------------------===// +AttributeImpl::~AttributeImpl() {} + bool AttributeImpl::hasAttribute(Attribute::AttrKind A) const { if (isStringAttribute()) return false; return getKindAsEnum() == A; |