diff options
| author | Petr Hosek <phosek@google.com> | 2021-08-25 01:12:19 -0700 |
|---|---|---|
| committer | Petr Hosek <phosek@google.com> | 2021-08-31 17:44:33 -0700 |
| commit | 92f54e1c752253b5a17eb9ec7942f580d878f64d (patch) | |
| tree | 914d039ebc13766cc6bbca1721b7a75eb0addf52 /llvm/lib/FileCheck/FileCheck.cpp | |
| parent | c2162e4d89d6f99bbbe96beaa9156dbb2dba8344 (diff) | |
| download | llvm-92f54e1c752253b5a17eb9ec7942f580d878f64d.zip llvm-92f54e1c752253b5a17eb9ec7942f580d878f64d.tar.gz llvm-92f54e1c752253b5a17eb9ec7942f580d878f64d.tar.bz2 | |
[Linker] Support weak symbols in nodeduplicate COMDAT group
When a nodeduplicate COMDAT group contains a weak symbol, choose
a non-weak symbol (or one of the weak ones) rather than reporting
an error. This should address issue PR51394.
With the current IR representation, a generic comdat nodeduplicate
semantics is not representable for LTO. In the linker, sections and
symbols are separate concepts. A dropped weak symbol does not force the
defining input section to be dropped as well (though it can be collected
by GC). In the IR, when a weak linkage symbol is dropped, its associate
section content is dropped as well.
For InstrProfiling, which is where ran into this issue in PR51394, the
deduplication semantic is a sufficient workaround.
Differential Revision: https://reviews.llvm.org/D108689
Diffstat (limited to 'llvm/lib/FileCheck/FileCheck.cpp')
0 files changed, 0 insertions, 0 deletions