diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-06-03 09:33:30 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-06-03 09:33:30 -0700 |
commit | 148c69dbae4c9993cad5f7e47f37a616b23f8537 (patch) | |
tree | 2ce82f8a2547eca07fef04ccada7e283eb1083d6 /llvm/lib/ExecutionEngine/Orc | |
parent | a9032712c453bda70449dedcaf00bead0fea6e88 (diff) | |
download | llvm-148c69dbae4c9993cad5f7e47f37a616b23f8537.zip llvm-148c69dbae4c9993cad5f7e47f37a616b23f8537.tar.gz llvm-148c69dbae4c9993cad5f7e47f37a616b23f8537.tar.bz2 |
[llvm] annotate interfaces in llvm/ExecutionEngine for DLL export (#140809)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/ExecutionEngine`
library. These annotations currently have no meaningful impact on the
LLVM build; however, they are a prerequisite to support an LLVM Windows
DLL (shared library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Add `LLVM_ABI_FRIEND` to friend member functions declared with
`LLVM_ABI`
- Add `LLVM_ABI` to a subset of private class methods and fields that
require export
- Add `LLVM_ABI` to a small number of symbols that require export but
are not declared in headers
- Add `LLVM_ABI` to a number of `extern "C"` methods that IDS missed
because they're implicitly exported
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'llvm/lib/ExecutionEngine/Orc')
-rw-r--r-- | llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp b/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp index fd62632..cb1b3b0 100644 --- a/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp +++ b/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp @@ -24,14 +24,13 @@ extern "C" { // We put information about the JITed function in this global, which the // debugger reads. Make sure to specify the version statically, because the // debugger checks the version before we can set it during runtime. -LLVM_ALWAYS_EXPORT -struct jit_descriptor __jit_debug_descriptor = {JitDescriptorVersion, 0, - nullptr, nullptr}; +LLVM_ABI LLVM_ALWAYS_EXPORT struct jit_descriptor __jit_debug_descriptor = { + JitDescriptorVersion, 0, nullptr, nullptr}; // Debuggers that implement the GDB JIT interface put a special breakpoint in // this function. -LLVM_ALWAYS_EXPORT -LLVM_ATTRIBUTE_NOINLINE void __jit_debug_register_code() { +LLVM_ABI LLVM_ALWAYS_EXPORT LLVM_ATTRIBUTE_NOINLINE void +__jit_debug_register_code() { // The noinline and the asm prevent calls to this function from being // optimized out. #if !defined(_MSC_VER) |