aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
diff options
context:
space:
mode:
authorNico Weber <thakis@chromium.org>2021-11-18 22:50:42 -0500
committerNico Weber <thakis@chromium.org>2021-11-19 09:19:53 -0500
commit4f9a5c2a1438c719f30f384c6bd9ac9290b882c0 (patch)
tree81e42b51fbfed4f8548bbbfb85a3a550aded619b /llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
parent6623c02d70c3732dbea59c6d79c69501baf9627b (diff)
downloadllvm-4f9a5c2a1438c719f30f384c6bd9ac9290b882c0.zip
llvm-4f9a5c2a1438c719f30f384c6bd9ac9290b882c0.tar.gz
llvm-4f9a5c2a1438c719f30f384c6bd9ac9290b882c0.tar.bz2
[asm] Remove explicit branch for modifier 'l'
No intended behavior change. EmitGCCInlineAsmStr() used to explicitly check for modifier 'l' after handling block address and machine basic block operands. This prevented passing a MachineOperand with 'l' modifier to PrintAsmMemoryOperand(). Conceptually that seems kind of nice, but in practice the overrides of PrintAsmMemoryOperand() in all (*) AsmPrinter subclasses already reject modifiers they don't know about, and none of them don't know about 'l'. So removing this doesn't have a behavior difference, is less code, and it makes EmitGCCInlineAsmStr() and EmitMSInlineAsmStr() more similar, to prepare for merging them later. (Why not _add_ the branch to EmitMSInlineAsmStr() instead? Because that always works with X86AsmPrinter I think, and X86AsmPrinter::PrintAsmMemoryOperand() very decisively rejects the 'l' modifier, so it's hard to motivate adding that branch.) *: The one exception was AVRAsmPrinter, which had an llvm_unreachable instead of returning true. So this commit changes that, so that the AVR target keeps emitting an error instead of crashing when passing a mem operand with a :l modifier to it. All the other targets already don't crash on this. Differential Revision: https://reviews.llvm.org/D114216
Diffstat (limited to 'llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp')
0 files changed, 0 insertions, 0 deletions