diff options
| author | Jorge Gorbe Moya <jgorbe@google.com> | 2022-05-23 11:29:10 -0700 |
|---|---|---|
| committer | Jorge Gorbe Moya <jgorbe@google.com> | 2022-05-23 11:31:53 -0700 |
| commit | f0a61c2ce2afec200967c59d45181c7a9fbe2c3f (patch) | |
| tree | b103e4a1d784792f9da64c2ec0066b1cac030cf0 /llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp | |
| parent | bedd3ee88152584b1c32c276b0ff38bb891f2812 (diff) | |
| download | llvm-f0a61c2ce2afec200967c59d45181c7a9fbe2c3f.zip llvm-f0a61c2ce2afec200967c59d45181c7a9fbe2c3f.tar.gz llvm-f0a61c2ce2afec200967c59d45181c7a9fbe2c3f.tar.bz2 | |
Remove `friend` classes from TypeCategoryMap
As far as I can tell, the only thing those friend classes access is the
`ValueSP` typedef.
Given that this is a map-ish class, with "Map" in its name, it doesn't
seem like a stretch to make `KeyType`, `ValueType` and `ValueSP` public.
More so when the public methods of the class have `KeyType` and
`ValueSP` arguments and clearly `ValueSP` needs to be accessed from the
outside.
`friend` complicates local reasoning about who can access private
members, which is valuable in a class like this that has every method
locking a mutex to prevent concurrent access.
Differential Revision: https://reviews.llvm.org/D126103
Diffstat (limited to 'llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions