aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
diff options
context:
space:
mode:
authorAmy Huang <akhuang@google.com>2020-07-21 16:54:52 -0700
committerAmy Huang <akhuang@google.com>2020-07-21 16:54:52 -0700
commit0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5 (patch)
tree01ec3875c81562d1b9c59d91c57ab17381c27a7b /llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
parenta361aa5249856e333a373df90947dabf34cd6aab (diff)
downloadllvm-0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5.zip
llvm-0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5.tar.gz
llvm-0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5.tar.bz2
[PDB][NativeSession] Clean up some things in NativeSession.
-Use the actual sect/offset to keep track of symbols in the cache so they don't get created multiple times with different addresses. -Remove getSymTag from PDBFunctionSymbol/PDBPublicSymbol because it's already implemented in the base class -Merge the symbolizer test files for DIA and native, since the tests are the same. -Implement getCompilandId for NativeLineNumber Reviewed By: amccarth Differential Revision: https://reviews.llvm.org/D84208
Diffstat (limited to 'llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp')
-rw-r--r--llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp6
1 files changed, 1 insertions, 5 deletions
diff --git a/llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp b/llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
index 2537daa..cd77fab 100644
--- a/llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
@@ -19,7 +19,7 @@ using namespace llvm::pdb;
NativeFunctionSymbol::NativeFunctionSymbol(NativeSession &Session,
SymIndexId Id,
const codeview::ProcSym &Sym)
- : NativeRawSymbol(Session, PDB_SymType::Data, Id), Sym(Sym) {}
+ : NativeRawSymbol(Session, PDB_SymType::Function, Id), Sym(Sym) {}
NativeFunctionSymbol::~NativeFunctionSymbol() {}
@@ -42,10 +42,6 @@ std::string NativeFunctionSymbol::getName() const {
return std::string(Sym.Name);
}
-PDB_SymType NativeFunctionSymbol::getSymTag() const {
- return PDB_SymType::Function;
-}
-
uint64_t NativeFunctionSymbol::getLength() const { return Sym.CodeSize; }
uint32_t NativeFunctionSymbol::getRelativeVirtualAddress() const {