diff options
| author | Kostya Kortchinsky <kostyak@google.com> | 2020-09-28 17:21:00 -0700 |
|---|---|---|
| committer | Kostya Kortchinsky <kostyak@google.com> | 2020-09-29 08:26:38 -0700 |
| commit | e456df77c2a5a2bf905f6848a09faf69b49c5752 (patch) | |
| tree | 0cf3858a050fcfe3d1b8a2081475bbfac0f2cdd7 /llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp | |
| parent | 01c95f79424d1083a6c06ed28c98c0a647b85711 (diff) | |
| download | llvm-e456df77c2a5a2bf905f6848a09faf69b49c5752.zip llvm-e456df77c2a5a2bf905f6848a09faf69b49c5752.tar.gz llvm-e456df77c2a5a2bf905f6848a09faf69b49c5752.tar.bz2 | |
[scudo][standalone] Fix Primary's ReleaseToOS test
Said test was flaking on Fuchsia for non-obvious reasons, and only
for ASan variants (the release was returning 0).
It turned out that the templating was off, `true` being promoted to
a `s32` and used as the minimum interval argument. This meant that in
some circumstances, the normal release would occur, and the forced
release would have nothing to release, hence the 0 byte released.
The symbols are giving it away (note the 1):
```
scudo::SizeClassAllocator64<scudo::FixedSizeClassMap<scudo::DefaultSizeClassConfig>,24ul,1,2147483647,false>::releaseToOS(void)
```
This also probably means that there was no MTE version of that test!
Differential Revision: https://reviews.llvm.org/D88457
Diffstat (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
0 files changed, 0 insertions, 0 deletions