diff options
| author | Reid Kleckner <rnk@google.com> | 2020-09-24 11:14:05 -0700 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2020-09-24 11:16:55 -0700 |
| commit | b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 (patch) | |
| tree | f4e9432d390b84de3f8bbb718af06a33db78e2e6 /llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp | |
| parent | 3453b6928da332bb67f902add71f5cd80f61c136 (diff) | |
| download | llvm-b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.zip llvm-b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.tar.gz llvm-b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.tar.bz2 | |
Revert "Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic"
This reverts commit 8e780a1653e6f87755a447e921b8f929d8b70996.
DiagnosticBuilder is a value type, created on the stack everywhere. IMO
we should not be adding a vtable to it, and making very operator<< use a
virtual interface. There are other feasible designs for implementing
this. The original review, D84362, was approved by @tra, who is
responsible for Clang's CUDA support, but it wasn't reviewed by @rsmith
or anyone responsible for clang's diagnostic library.
Diffstat (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
0 files changed, 0 insertions, 0 deletions