diff options
author | Puyan Lotfi <puyan@puyan.org> | 2020-08-10 14:45:38 -0400 |
---|---|---|
committer | Puyan Lotfi <puyan@puyan.org> | 2020-08-10 15:43:30 -0400 |
commit | 7bc03f55539f7f081daea5363f2e4845b2e75f57 (patch) | |
tree | d39e4e111b963549d4b679ba13bb68f88477f7e6 /llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp | |
parent | 4cd8e9b169f4dc5dde19807585c86f6d6113d3ff (diff) | |
download | llvm-7bc03f55539f7f081daea5363f2e4845b2e75f57.zip llvm-7bc03f55539f7f081daea5363f2e4845b2e75f57.tar.gz llvm-7bc03f55539f7f081daea5363f2e4845b2e75f57.tar.bz2 |
[MachineOutliner][AArch64] WA for multiple stack fixup cases in MachineOutliner.
In cases where MachineOutliner candidates either are:
* noreturn
* have calls with no available LR or free regs
* Don't use SP
we can end up hitting stack fixup code for the caller and the callee for
a FrameID of MachineOutlinerDefault. This triggers the assert:
`assert(OF.FrameConstructionID != MachineOutlinerDefault &&
"Can only fix up stack references once");`
in AArch64InstrInfo.cpp. This assert exists for now because a lot of the
fixup code is not tested to handle fixing up more than once and needs
some better checks and enhancements to avoid potentially generating
illegal code.
I've filed a Bugzilla report to track this until these cases are handled
by the AArch64 MachineOutliner: https://bugs.llvm.org/show_bug.cgi?id=46767
This diff detects cases that will cause these multiple stack fixups and
prune the Candidates from `RepeatedSequenceLocs`.
Differential Revision: https://reviews.llvm.org/D83923
Diffstat (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
0 files changed, 0 insertions, 0 deletions