diff options
author | Julian Lettner <julian.lettner@apple.com> | 2021-12-22 22:30:46 -0800 |
---|---|---|
committer | Julian Lettner <julian.lettner@apple.com> | 2022-01-07 12:28:38 -0800 |
commit | 6f480655e69a4ae0b1d4c3d749cece2716a6f43c (patch) | |
tree | 8f5dca9bc9c84a2abf34337ee8ba4283b4ede294 /llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp | |
parent | dfbe74be63c217f186fa24d322bac00bcd91851f (diff) | |
download | llvm-6f480655e69a4ae0b1d4c3d749cece2716a6f43c.zip llvm-6f480655e69a4ae0b1d4c3d749cece2716a6f43c.tar.gz llvm-6f480655e69a4ae0b1d4c3d749cece2716a6f43c.tar.bz2 |
[ASan][Darwin] Avoid crash during ASan initialization
Always pass `depth=1` to `vm_region_recurse_64()`. `depth` is a in-out
parameter and gets reset to 0 after the first call, so we incorrectly
pass `depth=0` on subsequent calls.
We want to avoid the following crash:
```
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000180000000
Exception Codes: 0x0000000000000001, 0x0000000180000000
VM Region Info: 0x180000000 is not in any region. Bytes after previous region: 277577729 Bytes before following region: 384270336
REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL
Stack 16f64c000-16f748000 [ 1008K] rw-/rwx SM=PRV thread 0
---> GAP OF 0x27730000 BYTES
unused shlib __TEXT 196e78000-196eac000 [ 208K] r-x/r-x SM=COW ... this process
Termination Reason: SIGNAL 11 Segmentation fault: 11
Terminating Process: exc handler [767]
```
Crashing code:
```
static mach_header *get_dyld_image_header() {
unsigned depth = 1;
vm_size_t size = 0;
vm_address_t address = 0;
kern_return_t err = KERN_SUCCESS;
mach_msg_type_number_t count = VM_REGION_SUBMAP_INFO_COUNT_64;
while (true) {
struct vm_region_submap_info_64 info;
err = vm_region_recurse_64(mach_task_self(), &address, &size, &depth,
(vm_region_info_t)&info, &count);
if (err != KERN_SUCCESS) return nullptr;
if (size >= sizeof(mach_header) && info.protection & kProtectionRead) {
mach_header *hdr = (mach_header *)address;
if ((hdr->magic == MH_MAGIC || hdr->magic == MH_MAGIC_64) && // << CRASH: sanitizer_procmaps_mac.cpp:176
hdr->filetype == MH_DYLINKER) {
return hdr;
}
}
address += size;
}
}
```
Radar-Id: rdar://problem/86773501
Differential Revision: https://reviews.llvm.org/D116240
Diffstat (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
0 files changed, 0 insertions, 0 deletions