aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
diff options
context:
space:
mode:
authorTeresa Johnson <tejohnson@google.com>2025-01-21 11:31:29 -0800
committerGitHub <noreply@github.com>2025-01-21 11:31:29 -0800
commit0ca6b2b0cc3a90e14da56a56bdfcf9911896ed4a (patch)
tree37db1f4831260834a2c4f84350ec55b8d41a40bf /llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
parent877012638278102206a09f5cb3ecab74db10eb91 (diff)
downloadllvm-0ca6b2b0cc3a90e14da56a56bdfcf9911896ed4a.zip
llvm-0ca6b2b0cc3a90e14da56a56bdfcf9911896ed4a.tar.gz
llvm-0ca6b2b0cc3a90e14da56a56bdfcf9911896ed4a.tar.bz2
[MemProf] Fix an incorrect iterator increment (#123438)
We pass in a pointer to an Edge iterator to moveEdgeToExistingCalleeClone, so that it can be correctly updated when we remove edges during an edge iteration. We were not dereferencing this pointer in one case, meaning we would increment the pointer and not the iterator as intended. This did not cause any issues, as it turns out that we would simply skip the edge on the next iteration as it was already appropriately handled. While in theory this incurred some extra compilation time, in practice for a large application the effect was not significant. I confirmed that there was no effect to any cloning from the fix. I plan to send a follow up change to avoid the need to pass in an iterator at all and simplify / consolidate the handling in the caller, but want to fix this in case something requires a revert of the follow on fix.
Diffstat (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
0 files changed, 0 insertions, 0 deletions