diff options
| author | George Burgess IV <george.burgess.iv@gmail.com> | 2016-09-20 21:30:01 +0000 |
|---|---|---|
| committer | George Burgess IV <george.burgess.iv@gmail.com> | 2016-09-20 21:30:01 +0000 |
| commit | b44b6d98b3a16942e2761c2f30a5099751ee805e (patch) | |
| tree | ff91b6ca4026bc7047ce6f565b8b3a424c65025f /llvm/lib/CodeGen/StackProtector.cpp | |
| parent | bf04708e11623f3bc2ac6ca807213079e9173ee2 (diff) | |
| download | llvm-b44b6d98b3a16942e2761c2f30a5099751ee805e.zip llvm-b44b6d98b3a16942e2761c2f30a5099751ee805e.tar.gz llvm-b44b6d98b3a16942e2761c2f30a5099751ee805e.tar.bz2 | |
[CodeGen] stop short-circuiting the SSP code for sspstrong.
This check caused us to skip adding layout information for calls to
alloca in sspreq/sspstrong mode. We check properly for sspstrong later
on (and add the correct layout info when doing so), so removing this
shouldn't hurt.
No test is included, since testing this using lit seems to require
checking for exact offsets in asm, which is something that the lit tests
for this avoid. If someone cares deeply, I'm happy to write a unittest
or something to cover this, but that feels like overkill.
Patch by Daniel Micay.
Differential Revision: https://reviews.llvm.org/D22714
llvm-svn: 282022
Diffstat (limited to 'llvm/lib/CodeGen/StackProtector.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/StackProtector.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/llvm/lib/CodeGen/StackProtector.cpp b/llvm/lib/CodeGen/StackProtector.cpp index fa06113..c2c010a 100644 --- a/llvm/lib/CodeGen/StackProtector.cpp +++ b/llvm/lib/CodeGen/StackProtector.cpp @@ -236,11 +236,6 @@ bool StackProtector::RequiresStackProtector() { for (const Instruction &I : BB) { if (const AllocaInst *AI = dyn_cast<AllocaInst>(&I)) { if (AI->isArrayAllocation()) { - // SSP-Strong: Enable protectors for any call to alloca, regardless - // of size. - if (Strong) - return true; - if (const auto *CI = dyn_cast<ConstantInt>(AI->getArraySize())) { if (CI->getLimitedValue(SSPBufferSize) >= SSPBufferSize) { // A call to alloca with size >= SSPBufferSize requires |