diff options
| author | Eric Fiselier <eric@efcs.ca> | 2018-02-01 23:47:54 +0000 |
|---|---|---|
| committer | Eric Fiselier <eric@efcs.ca> | 2018-02-01 23:47:54 +0000 |
| commit | 8ed97272ab5402e47113adcf03d83f7392e20d49 (patch) | |
| tree | 52566f529e3c0517abd598f058b5609753dfacd4 /llvm/lib/CodeGen/SplitKit.cpp | |
| parent | 17324d8b340dd9a3e22a94191b15ebf07a41fcc9 (diff) | |
| download | llvm-8ed97272ab5402e47113adcf03d83f7392e20d49.zip llvm-8ed97272ab5402e47113adcf03d83f7392e20d49.tar.gz llvm-8ed97272ab5402e47113adcf03d83f7392e20d49.tar.bz2 | |
[coroutines] Fix application of NRVO to Coroutine "Gro" or return object.
Summary:
Fix NRVO for Gro variable.
Previously, we only marked the GRO declaration as an NRVO variable
when its QualType and the function return's QualType matched exactly
(using operator==). However, this was incorrect for two reasons:
1. We were marking non-class types, such as ints, as being NRVO variables.
2. We failed to handle cases where the canonical types were the same, but the actual `QualType` objects were different. For example, if one was represented by a typedef. (Example: https://godbolt.org/g/3UFgsL)
This patch fixes these bugs by marking the Gro variable as supporting NRVO only
when `BuildReturnStmt` marks the Gro variable as a coroutine candidate.
Reviewers: rsmith, GorNishanov, nicholas
Reviewed By: GorNishanov
Subscribers: majnemer, cfe-commits
Differential Revision: https://reviews.llvm.org/D42343
llvm-svn: 324037
Diffstat (limited to 'llvm/lib/CodeGen/SplitKit.cpp')
0 files changed, 0 insertions, 0 deletions